fix(proto): prevent PATH_CHALLENGE/RESPONSE from being sent in datagrams that can't be expanded#699
Open
divagant-martian wants to merge 1 commit into
Open
Conversation
divagant-martian
added
the
compliance
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/699/docs/noq/ Last updated: 2026-06-09T16:05:47Z |
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5507.7 Mbps | 7940.6 Mbps | -30.6% | 96.2% / 100.0% |
| medium-concurrent | 5508.3 Mbps | 7856.0 Mbps | -29.9% | 96.5% / 148.0% |
| medium-single | 4172.7 Mbps | 4665.4 Mbps | -10.6% | 98.0% / 151.0% |
| small-concurrent | 3803.6 Mbps | 5181.7 Mbps | -26.6% | 94.5% / 102.0% |
| small-single | 3536.8 Mbps | 4760.0 Mbps | -25.7% | 93.6% / 103.0% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3105.9 Mbps | N/A | N/A |
| lan | 782.4 Mbps | N/A | N/A |
| lossy | 69.9 Mbps | N/A | N/A |
| wan | 83.8 Mbps | N/A | N/A |
Summary
noq is 25.9% slower on average
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Philipp's monkeys generated a case in which path challenges are sent on the
second datagram of a batch, where the first one is smaller than the required
MIN_INITIAL_SIZE. This causes a misalignment of the batch since these framesmust be sent on expanded datagrams.
Breaking Changes
n/a
Notes & open questions
Regression test is in #694
Change checklist